On Wed, Nov 03, 2021 at 03:59:25PM +0100, Jürgen Spitzmüller wrote: > Am Mi., 3. Nov. 2021 um 15:17 Uhr schrieb Pavel Sanda <sa...@lyx.org>: > > > I am afraid unless we want to revamp the whole toc update machinery we just > > shouldn't by default that expect toc_ is nonempty. > > > > This means that my patch which checks for toc_ emptiness should go in, > right?
Well, nothing against this particular patch, but the problem is that if we accept that models_.find(type) might sucesfully return hashes which are actually bogus, then all other models_.find occurences might be in the same danger. So yes, this particular crash is gone, but other corner cases might be lurking around. The comments in various TocModel classess/attributes are such that I struggle to understand what they are supposed to represent and what should I expect or not. Pavel -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
