On Thu, 6 Feb 2025 at 12:53, Jean-Marc Lasgouttes <lasgout...@lyx.org>
wrote:

> Le 06/02/2025 à 12:19, Scott Kostyshak a écrit :
> >> mathed/InsetMathSymbol.cpp: In member function 'virtual void
> lyx::InsetMathSymbol::mathmlize(lyx::MathMLStream&) const':
> >> mathed/InsetMathSymbol.cpp:167:20: error: 'strcmp' was not declared in
> this scope
> >>    167 |         } else if (strcmp(sym_->MathMLtype(), "mi") == 0) {
> >>        |                    ^~~~~~
> >> mathed/InsetMathSymbol.cpp:27:1: note: 'strcmp' is defined in header
> '<cstring>'; this is probably fixable by adding '#include <cstring>'
> >>     26 | #include "support/textutils.h"
> >>    +++ |+#include <cstring>
> >>     27 | #include "support/unique_ptr.h"
>
> > Hi Thibaut,
> >
> > I'm guessing this was triggered from the recent work you've done. Can
> > you take a look?
>
> Hi there,
>
> I would suggets to change MathMLtype() to return a std::string. And to
> use an initial lowercase letter.
>

I implemented this suggestion (it required a bit of ground work due to the
places this function is used) in 87f08ce2.

I bet this compilation error is a compiler difference: MSVC didn't complain
at all about the missing include!
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
https://lists.lyx.org/mailman/listinfo/lyx-devel

Reply via email to