On Sun, 2025-06-29 at 15:28 +0200, Scott Kostyshak wrote:
> Are these worth looking into?

AFAICS all of these seem harmless.

For example:
> /home/scott/lyxbuilds/master-master/repo/src/TextMetrics.cpp:1381:33: warning:
> implicit conversion from 'depth_type' (aka 'unsigned long') to 'double' may
> lose precision [-Wimplicit-int-float-conversion]
>  1381 |         return int(layoutdesc * 2 / (2 + pars[pit].getDepth()));
>       |                                   ~  ~~^~~~~~~~~~~~~~~~~~~~~~ 

For this to happen the depth should be an insane value that is very far from any
value that we use.

We can use a static cast to make it clear the intent but then the code will
become difficult to read defeating the original purpose. :-)
-- 
José Abílio
-- 
lyx-devel mailing list
[email protected]
https://lists.lyx.org/mailman/listinfo/lyx-devel

Reply via email to