Am Mon, 14 Jul 2025 12:09:01 +0200 schrieb Scott Kostyshak <skost...@lyx.org>:
> On Mon, Jul 14, 2025 at 08:59:32AM +0200, Kornel Benko wrote:
> > Am Mon, 14 Jul 2025 01:00:43 +0200
> > schrieb Scott Kostyshak <skost...@lyx.org>:
> >
> > > > /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/stl_construct.h:88:2:
> > > > error: destructor called on non-final 'lyx::support::ForkedCall' that
> > > > has virtual
> > > > functions but non-virtual destructor
> > > > [-Werror,-Wdelete-non-abstract-non-virtual-dtor]
> > >
> > > That seems to have been addressed. Now I tested and all the warnings are
> > > gone. Thanks for cleaning those up! I've turned the flag on to catch any
> > > future instance.
> > >
> > > Scott
> >
> > Not so fast. I still see a problem with clang18.
> > ...
> > In file included from /usr2/src/lyx/lyx-test/src/support/ForkedCalls.cpp:15:
> > In file included from /usr2/src/lyx/lyx-test/src/support/ForkedCalls.h:17:
> > In file included from /usr2/src/lyx/lyx-test/src/support/signals.h:15:
> > In file included from /usr2/src/lyx/lyx-test/3rdparty/nod/nod.hpp:4:
> > In file included from
> > /usr/bin/../lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/vector:62:
> > In file
> > included from
> > /usr/bin/../lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/stl_algobase.h:67:
> > In file included from
> > /usr/bin/../lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/stl_iterator.h:78:
> > /usr/bin/../lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/stl_construct.h:88:2:
> > error: destructor called on non-final 'lyx::support::ForkedCall' that has
> > virtual
> > functions but non-virtual destructor
> > [-Werror,-Wdelete-non-abstract-non-virtual-dtor]
> > 88 | __location->~_Tp();
> > ...
>
> How do you reproduce this on current master? Because I think we
> currently append -Wno-delete-non-abstract-non-virtual-dtor. Do you use a
> local patch to remove that?
>
> Scott
In commenting the lines
$ find . -name CMakeLists.txt | xargs egrep -n
delete-non-abstract-non-virtual-dtor
-->
./src/tex2lyx/CMakeLists.txt:45:
handle_source_option("CXX" ${TOP_SRC_DIR}/src/${_base}.cpp
-Wno-delete-non-abstract-non-virtual-dtor)
./src/support/CMakeLists.txt:45:
handle_source_option("CXX" ${TOP_SRC_DIR}/src/support/ForkedCalls.cpp
-Wno-delete-non-abstract-non-virtual-dtor)
./src/graphics/CMakeLists.txt:25:
handle_source_option("CXX" ${TOP_SRC_DIR}/src/graphics/${_base}.cpp
-Wno-delete-non-abstract-non-virtual-dtor)
./src/tests/CMakeLists.txt:131:
handle_source_option("CXX" ${TOP_SRC_DIR}/src/${_base}.cpp
-Wno-delete-non-abstract-non-virtual-dtor)
./src/frontends/qt/CMakeLists.txt:36:
handle_source_option("CXX" ${TOP_SRC_DIR}/src/frontends/qt/${_base}.cpp
-Wno-delete-non-abstract-non-virtual-dtor)
./src/CMakeLists.txt:75:
handle_source_option("CXX" ${TOP_SRC_DIR}/src/${_base}.cpp
-Wno-delete-non-abstract-non-virtual-dtor)
Kornel
pgp4Eprql8YrH.pgp
Description: Digitale Signatur von OpenPGP
-- lyx-devel mailing list lyx-devel@lists.lyx.org https://lists.lyx.org/mailman/listinfo/lyx-devel
