On Mon, Jul 14, 2025 at 03:51:03PM +0200, Jean-Marc Lasgouttes wrote: > Le 14/07/2025 à 14:41, Yokota K. a écrit : > > Along with the 3/ plan, I hope the attached patch suppresses the warnings, > > but I’m not sure how much of resemblance of functions leads to a warning > > (it still uses overloaded text() functions). > > Looks good to me. What is not good is when you overload a method in a > derived class. In this case, you should reimplement the original function in > the new class too (or just use "using oldclass::mymethod(arg1, arg2)" or > something like that). > > > Input-method-related overloaded functions of PainterInfo::draw(), > > Inset::draw() and InsetMathChar::draw() now have the name of > > drawWithInputMethod(). > > My original idea was to declare it only for InsetMathChar, not Inset. > > I'll let Scott test it.
Thanks for working on this, Koji! Tested the patch and it does make the warning about Inset.h:217 go away. Scott
signature.asc
Description: PGP signature
-- lyx-devel mailing list lyx-devel@lists.lyx.org https://lists.lyx.org/mailman/listinfo/lyx-devel
