On Sat, Aug 02, 2025 at 11:35:10AM +0200, Kornel Benko wrote: > Am Sat, 2 Aug 2025 11:13:06 +0200 > schrieb Scott Kostyshak <skost...@lyx.org>: > > > On Sat, Aug 02, 2025 at 11:00:48AM +0200, Kornel Benko wrote: > > > Am Fri, 01 Aug 2025 14:30:47 +0000 > > > schrieb Scott Kostyshak <skost...@lyx.org>: > > > > > > > commit 6ee67ae6823ded6e486fe9f8496e27e371308ac4 > > > > Author: Scott Kostyshak <skost...@lyx.org> > > > > Date: Fri Aug 1 16:29:41 2025 +0200 > > > > > > > > lyx-tester: turn on more GCC warnings > > > > > > > > These do not currently report any instances. > > > > --- > > > > development/lyx-tester/lyxbuild | 10 ++++++++++ > > > > 1 file changed, 10 insertions(+) > > > > > > > > diff --git a/development/lyx-tester/lyxbuild > > > > b/development/lyx-tester/lyxbuild > > > > index 31deb50949..cc059f8e5e 100755 > > > > --- a/development/lyx-tester/lyxbuild > > > > +++ b/development/lyx-tester/lyxbuild > > > > @@ -685,6 +685,16 @@ else > > > > # by default. > > > > # https://reviews.llvm.org/D119361 > > > > CPPFLAGS+=";-Wno-missing-declarations" > > > > + > > > > + CPPFLAGS+=";-Wno-defaulted-function-deleted" > > > > + CPPFLAGS+=";-Wcomma-subscript" > > > > + CPPFLAGS+=";-Wctor-dtor-privacy" > > > > + CPPFLAGS+=";-Wdeprecated" > > > > + CPPFLAGS+=";-Winvalid-imported-macros" > > > > + CPPFLAGS+=";-Wmismatched-tags" > > > > + CPPFLAGS+=";-Wsuggest-final-types" > > > > + CPPFLAGS+=";-Wsuggest-final-methods" > > > > + CPPFLAGS+=";-Wmaybe-uninitialized" > > > > fi > > > > > > > > # Good candidates to clean up, but not urgent. > > > > > > There are really many files (~ 250) needed to check for > > > -Wsuggest-final-types and > > > -Wsuggest-final-methods. > > > > For GCC? None of them trigger any warnings for me with GCC. > > > > Scott > > Yes, gcc14. The attached was needed for cmake build to compile.
Interesting. Maybe one of my other flags supercedes those. Attached is my build command (with -Werror) that succeeds with GCC 15. In any case, if it is the "suggest-final-*" flags that seem to cause the most issues, I can just remove those two. Scott
LYX_GIT_REPO="$( pwd )" &&
rm -rf ../CMakeBuild &&
export CC=gcc &&
export CXX=g++ &&
mkdir ../CMakeBuild &&
cd ../CMakeBuild &&
cmake -Wdev -Werror=dev "${LYX_GIT_REPO}" -DCMAKE_INSTALL_PREFIX=/usr/local
-DLYX_DEBUG=ON -DLYX_RELEASE=OFF -DLYX_CPACK=ON -DLYX_PROGRAM_SUFFIX=OFF
-DLYX_LOCALVERSIONING=ON -DCPACK_BINARY_DEB:BOOL=ON -DCPACK_BINARY_RPM:BOOL=OFF
-DCPACK_BINARY_NSIS:BOOL=OFF -DCPACK_BINARY_STGZ:BOOL=OFF
-DCPACK_BINARY_TGZ:BOOL=OFF -DCPACK_BINARY_TBZ2:BOOL=OFF
-DCPACK_BINARY_TZ:BOOL=OFF -DCPACK_SOURCE_TGZ:BOOL=ON
-DCPACK_SOURCE_TBZ2:BOOL=OFF -DCPACK_SOURCE_TZ:BOOL=OFF
-DCPACK_SOURCE_ZIP:BOOL=OFF -DLYX_HUNSPELL=ON -DLYX_EXTERNAL_HUNSPELL=ON
-DLYX_ENCHANT=ON -DLYX_EXTERNAL_Z=ON -DLYX_EXTERNAL_DTL=ON
-DLYX_EXTERNAL_ICONV=ON -DLYX_NLS=ON -DLYX_ENABLE_URLTESTS=OFF
-DLYX_ENABLE_EXPORT_TESTS=ON -DLYX_ENABLE_KEYTESTS=OFF -DLYX_PROFILE=ON
-DLYX_USE_QT=QT6
-DLYX_CXX_FLAGS_EXTRA='-Wextra;-Werror;-pedantic;-Wextra-semi;-Wmissing-include-dirs;-fmax-errors=1;-Wlogical-op;-Wduplicated-cond;-Wduplicated-branches;-fdelete-null-pointer-checks;-Wnull-dereference;-Wno-useless-cast;-Wno-missing-declarations;-Wno-defaulted-function-deleted;-Wcomma-subscript;-Wctor-dtor-privacy;-Wdeprecated;-Winvalid-imported-macros;-Wmismatched-tags;-Wsuggest-final-types;-Wsuggest-final-methods;-Wmaybe-uninitialized;-Wno-suggest-override;-Wno-redundant-tags;-Wno-sign-promo;-Wno-multiple-inheritance;-Wno-abi-tag;-Wno-float-equal;-Wcast-qual;-Wno-padded;-Wno-shadow;-Wno-effc++;-Wno-non-virtual-dtor;-Wno-aggregate-return;-Wcast-align;-Wformat=2;-Wpointer-arith;-Wsequence-point;-Wswitch;-Wunused-but-set-parameter;-Wwrite-strings;-Wredundant-decls;-Wundef;-Wno-implicit-fallthrough;-Wdouble-promotion;-Wmisleading-indentation;-Wno-sign-conversion;-Wno-conversion;-Woverloaded-virtual;-Wunused;-Wno-old-style-cast;-Wunused-macros;-Wno-missing-noreturn'
-DLYX_STDLIB_DEBUG=OFF -DLYX_DEBUG_GLIBC=OFF -DLYX_DEBUG_GLIBC_PEDANTIC=OFF &&
make -j4 &&
python3 ../repo/lib/configure.py &&
echo 'all done.'
signature.asc
Description: PGP signature
-- lyx-devel mailing list lyx-devel@lists.lyx.org https://lists.lyx.org/mailman/listinfo/lyx-devel
