Am 30.10.25 um 08:27 schrieb Kornel Benko:
Am Wed, 29 Oct 2025 20:48:24 +0100
schrieb Georg Baum <[email protected]>:
This would look like the attached. I also used the more specific
target_* commands (to slightly modernize the CMake code). The new syntax
is already supported by CMake 3.10, so no need to bump
cmake_minimum_required.
Opinions?
Georg
Looks good. But now errors in creating zlib:
cc1plus: error: /usr2/src/lyx/lyx-test/3rdparty/zlib/SYSTEM: No such file or
directory
[-Werror=missing-include-dirs]
...
We have:
target_include_directories(zlibstatic PUBLIC SYSTEM
${CMAKE_CURRENT_BINARY_DIR}
Maybe SYSTEM is not handled after PUBLIC in target_include_directories()?
Removing 'SYSTEM' cures the compilation.
Also using SYSTEM _before_ PUBLIC seems to work.
Yes. I first got the order wrong (because it is different for
include_directories and target_include_directories), seems I did not
change all occurences. For target_include_directories SYSTEM has to come
first:
https://cmake.org/cmake/help/latest/command/target_include_directories.html#command:target_include_directories
Georg
--
lyx-devel mailing list
[email protected]
https://lists.lyx.org/mailman/listinfo/lyx-devel
