Le 30/11/2025 à 21:47, Jean-Marc Lasgouttes a écrit :
tl;dr: I would just remove the forceBufferUpdate() thing.
My question is rather whether it was right to add the
forceBufferUpdate() in 5577e877. Indeed, before this commit, update
meant "update metrics" and not "update buffer".
This is fixed at db5a8b9dcd59. Riki, this is candidate for 2.5.x.
Actually, this is a new situation since I changed it at 9fd397ac1cb.
Before that, the "update" return value meant "Please compute all metrics".
I have adapted the code to this in 3674eede7. While less important, it
is candidate for 2.5.x too. This one potentially adds an extra full
metrics computation, so it is safe IMO.
So as a cleanup I would additionally remove this "update" return value
altogether. It is the responsability of notifyLeaveInset and friends to
set Update::Force when necessary. There is the question of FitCursor
that is not clear to me yet. I can take care of that cleanup.
This is more complicated and kept for later.
JMarc
--
lyx-devel mailing list
[email protected]
https://lists.lyx.org/mailman/listinfo/lyx-devel
