On Mon, Dec 15, 2025 at 06:55:41PM +0100, Kornel Benko wrote:
> Am Mon, 15 Dec 2025 16:10:44 +0100
> schrieb Scott Kostyshak <[email protected]>:
> ...
> > > From what I understand, -DNDEBUG is more of a release flag. So I wonder
> > > if it makes sense for you to remove it from your set of development
> > > flags looking at warnings. That said, I don't know what I'm talking
> > > about so I could have misunderstood.  
> > 
> > Kornel, I can no longer reproduce. For example, in my make log I set both
> > -Wmissing-noreturn -DNDEBUG and all seems to go well. Further, I removed 
> > setting
> > "no-missing-noreturn" in CMakeLists. Just to show that the flags are used, 
> > here's
> > output from my make log:
> > 
> > cd /home/scott/lyxbuilds/master-master/CMakeBuild/src/insets && 
> > /usr/lib/ccache/clang++
> > -DQT_CORE_LIB -DQT_GUI_LIB -I/home/scott/lyxbuilds/master-master/CMakeBuild
> > -I/home/scott/lyxbuilds/master-master/repo/src -I/usr/include/enchant-2
> > -I/usr/include/hunspell 
> > -I/home/scott/lyxbuilds/master-master/repo/3rdparty/nod
> > -I/home/scott/lyxbuilds/master-master/repo/src/insets -isystem
> > /usr/include/x86_64-linux-gnu/qt6/QtGui -isystem 
> > /usr/include/x86_64-linux-gnu/qt6
> > -isystem /usr/include/x86_64-linux-gnu/qt6/QtCore -isystem
> > /usr/lib/x86_64-linux-gnu/qt6/mkspecs/linux-g++ -DENABLE_ASSERTIONS=1
> > -fno-strict-aliasing  -O0 -g3 -std=c++20 -Wall -Wextra -Wno-deprecated-copy 
> > -Werror
> > -pedantic -Wextra-semi -Wmissing-include-dirs -ferror-limit=1 
> > -Wheader-hygiene
> > -Wno-pre-c++17-compat -Wno-c++98-compat -Wno-implicit-int-float-conversion
> > -Wno-unreachable-code-return -Wstring-conversion 
> > -Wno-reserved-macro-identifier
> > -Wno-documentation-html -Wused-but-marked-unused -Wdeprecated-copy-with-dtor
> > -Wdelete-non-virtual-dtor -Wno-float-equal -Wcast-qual -Wno-padded 
> > -Wno-shadow
> > -Wno-effc++ -Wno-non-virtual-dtor -Wno-aggregate-return -Wcast-align 
> > -Wformat=2
> > -Wpointer-arith -Wsequence-point -Wswitch -Wunused-but-set-parameter 
> > -Wwrite-strings
> > -Wredundant-decls -Wundef -Wno-implicit-fallthrough -Wdouble-promotion
> > -Wmisleading-indentation -Wno-sign-conversion -Wno-conversion 
> > -Woverloaded-virtual
> > -Wunused -Wno-old-style-cast -Wunused-macros -Wmissing-noreturn -DNDEBUG
> > -Wno-nested-anon-types -Wno-deprecated-declarations  -Wno-shadow -MD -MT
> > src/insets/CMakeFiles/insets.dir/InsetBibtex.cpp.o -MF
> > CMakeFiles/insets.dir/InsetBibtex.cpp.o.d -o 
> > CMakeFiles/insets.dir/InsetBibtex.cpp.o -c
> > /home/scott/lyxbuilds/master-master/repo/src/insets/InsetBibtex.cpp
> > 
> > Can you still reproduce the error? If yes, can you give me your build
> > commands to see if I can reproduce?
> > 
> > Scott
> 
> The error shows at file src/LyX.cpp using gcc-14, see attached
> 
>       Kornel

Thanks, I can't reproduce with GCC 15.0.1. (build commands attached)

I guess let's wait until you can try 15.0.1 and see if you can still
reproduce then. If so, must be another difference between our build
setups.

Scott
LYX_GIT_REPO="$( pwd )" &&
rm -rf ../CMakeBuild &&
rm -rf ../user-dir &&
export CC=gcc &&
export CXX=g++ &&
mkdir ../CMakeBuild &&
mkdir ../user-dir &&
cd ../CMakeBuild &&
cmake -Wdev -Werror=dev "${LYX_GIT_REPO}" -DCMAKE_INSTALL_PREFIX=/usr/local 
-DLYX_DEBUG=ON -DLYX_RELEASE=OFF -DLYX_CPACK=ON -DLYX_PROGRAM_SUFFIX=OFF 
-DLYX_LOCALVERSIONING=ON -DCPACK_BINARY_DEB:BOOL=ON -DCPACK_BINARY_RPM:BOOL=OFF 
-DCPACK_BINARY_NSIS:BOOL=OFF -DCPACK_BINARY_STGZ:BOOL=OFF 
-DCPACK_BINARY_TGZ:BOOL=OFF -DCPACK_BINARY_TBZ2:BOOL=OFF 
-DCPACK_BINARY_TZ:BOOL=OFF -DCPACK_SOURCE_TGZ:BOOL=ON 
-DCPACK_SOURCE_TBZ2:BOOL=OFF -DCPACK_SOURCE_TZ:BOOL=OFF 
-DCPACK_SOURCE_ZIP:BOOL=OFF -DLYX_HUNSPELL=ON -DLYX_EXTERNAL_HUNSPELL=ON 
-DLYX_ENCHANT=ON -DLYX_EXTERNAL_Z=ON -DLYX_EXTERNAL_DTL=ON 
-DLYX_EXTERNAL_ICONV=ON -DLYX_NLS=ON -DLYX_ENABLE_URLTESTS=OFF 
-DLYX_ENABLE_EXPORT_TESTS=ON -DLYX_ENABLE_KEYTESTS=OFF -DLYX_PROFILE=ON 
-DLYX_USE_QT=QT6 
-DLYX_CXX_FLAGS_EXTRA='-Wextra;-Werror;-pedantic;-Wextra-semi;-Wmissing-include-dirs;-fmax-errors=1;-Wlogical-op;-Wduplicated-cond;-Wduplicated-branches;-Wno-useless-cast;-Wno-missing-declarations;-Wno-defaulted-function-deleted;-Wcomma-subscript;-Wctor-dtor-privacy;-Wdeprecated;-Winvalid-imported-macros;-Wmismatched-tags;-Wmaybe-uninitialized;-Wno-suggest-final-types;-Wno-suggest-final-methods;-fdelete-null-pointer-checks;-Wno-null-dereference;-Wno-suggest-override;-Wno-redundant-tags;-Wno-sign-promo;-Wno-multiple-inheritance;-Wno-abi-tag;-Wno-float-equal;-Wcast-qual;-Wno-padded;-Wno-shadow;-Wno-effc++;-Wno-non-virtual-dtor;-Wno-aggregate-return;-Wcast-align;-Wformat=2;-Wpointer-arith;-Wsequence-point;-Wswitch;-Wunused-but-set-parameter;-Wwrite-strings;-Wredundant-decls;-Wundef;-Wno-implicit-fallthrough;-Wdouble-promotion;-Wmisleading-indentation;-Wno-sign-conversion;-Wno-conversion;-Woverloaded-virtual;-Wunused;-Wno-old-style-cast;-Wunused-macros;-Wmissing-noreturn;-DNDEBUG'
 -DLYX_STDLIB_DEBUG=OFF -DLYX_DEBUG_GLIBC=OFF -DLYX_DEBUG_GLIBC_PEDANTIC=OFF &&
make -j1 &&
cd ../user-dir &&
python3 "${LYX_GIT_REPO}/lib/configure.py" &&
echo 'all done.'

Attachment: signature.asc
Description: PGP signature

-- 
lyx-devel mailing list
[email protected]
https://lists.lyx.org/mailman/listinfo/lyx-devel

Reply via email to