On Wed, 2026-09-09 at 11:34 +0200, Pavel Sanda wrote:
> On Wed, Sep 09, 2026 at 09:53:07AM +0100, José Matos wrote:
> > > I am happy to ditch, but I saw explicit checks on python 2 while
> > > going through the code yesterday, eg in Graphicsconverter.
> > 
> > When I did the change I have only checked the python code, not C++.
> > Good catch.
> 
> I see. I instructed our silicon colleague to look around for other remnants
> if you interested. Below the findings and patches avaliable for adoption.

The patches are all reasonable and can/should be applied.

When I applied ruff to check the python code in development I had almost 300
warnings. With some, not too much, work I reduced this to 1!

This corresponds to assignment to unused variable `lyxtemplate` in
tools/generate_symbols_images.py


The issue now is to decide what scripts are used and what script can be retired.

Your friend :-) already identified some of those files:

For example those in section B:
"ACTIVELY BREAKS -- runs under python 2, or fails to start at all."

keystest/keytest.py             
keystest/cache-bisect.py        
keystest/make_screenshot_html.py


There are others like the tools/*symbols*.py that I am not sure if they are
still used.

> I leave it to you and Kornel to review and decide what to ship and what not
> regarding python2 transition. The case for lyxblogger seems clear though ;)
> 
> We could probably let clause to go through each item in configure.py and
> decide
> on obsoletness... Some other day ;)
> 
> Pavel

Best regards,
-- 
José Abílio
-- 
lyx-devel mailing list
[email protected]
https://lists.lyx.org/mailman/listinfo/lyx-devel

Reply via email to