> > In BufferView_pimpl.C:1036
> > in the function void BufferView::Pimpl::cursorToggle()
> > the function sigchldhandler(int, int *)
> > is called, which is a function from the spellcheck code.
> > Shouldn't sigchldchecker(int, int *) be called instead?
>
> Why do you think this is the right one to call?

Because when you're not spellchecking it seems to be the only function that's 
called anyway:

void sigchldhandler(pid_t pid, int * status)
{
#ifndef USE_PSPELL
        if (isp_pid > 0)
                if (pid == isp_pid) {
                        isp_pid= -1;
                        fcntl(isp_fd, F_SETFL, O_NONBLOCK); 
                }
#endif
        sigchldchecker(pid, status);
}

and because it seems a strange place to handle isp_pid. Shouldn't this be 
done in the spellchecker instead of the bufferview code? Although I admit 
that I don't really know what both sigchldchecker/handler are about. I am 
trying to move the spellchecker to frontends so I'd like to remove this 
dependency on the spellcheck code.

gr.ed.

Reply via email to