On Wed, Sep 12, 2001 at 12:23:28PM +0200, Jean-Marc Lasgouttes wrote: > I would like to merge the two versions of Paragraph::asString that we > have. Why not do it after 1.2.0 ? > - use of getChar or getUChar. I guess getUChar is better, but I'd like > a confirmation No. getUChar should not be used in Paragraph::asString(Buffer *,bool) > - one version only outputs math insets as ascii, the other one does > this for all insets Suppose you have a section paragraph with a label inset. You probably don't want the label to appear in the TOC. However, when you copy a selection to an external program, do you want to have the label or not ? Furthermore, wouldn't it better to output the inset as latex (or linuxdoc/docbook, according to the class of the doc) ? > - one version remove carriage returns, the other does not If you have a matrix in a section, you don't want carriage returns in the string for the TOC. At least with XForms, it causes problems. > - one version does rtl handling, the other does not It is needed only for the string for the TOC _and_ the auto-label initialization code. It appears that the two asString() methods are quite different, and it would be ugly if you combine them (lots of if).
