On Friday 23 November 2001 1:09 pm, Jean-Marc Lasgouttes wrote: > >>>>> "John" == John Levon <[EMAIL PROTECTED]> writes: > > John> looks like a big patch, but really it just moves the code into a > John> better place ... > > This is certainly good, but the _pimpl separation is not the thing to > do IMO. What about adding a few signals for the alerts in > frontends/Dialogs.h (or somewhere else) and put the Alert.C xforms > code in frontends/xforms? This is the thing to do to be able to > implement the GUI-I alerts, if I understand correctly. > > Note that, if you agree it would be better, I can nevertheless apply > your patch, since it is so invasive (and would easily break later). > > JMarc
I would suggest applying it as-is. The signals or however else this is to be done can be applied at a later point. Angus
