Re: ControlInset failling Assert()

[Allan Rae]

On Tue, 15 Jan 2002, Angus Leeming wrote:
[...]
> Nonetheless, I think you've hit on a bug. Well done! Although I don't think
> it'll help solve your problem, the fix to that particular problem is:
>
> template <class Inset, class Params>
> void ControlInset<Inset, Params>::apply()
> {
>       if (lv_.buffer()->isReadonly())
>               return;
>
>       view().apply();
>
> -     if (inset_ && params() != getParams(*inset_))
> +     if (inset_)
> +             if (params() != getParams(*inset_))
>                       applyParamsToInset();
>       else
>               applyParamsNoInset();

I hope you realise you just made another bug with nested else because
that will be interpreted as:

        if (inset_) {
                if (params() != getParams(*inset_)) {
                        applyParamsToInset();
                } else {
                        applyParamsNoInset();
                }
        }

instead of what you really wanted:

        if (inset_) {
                if (params() != getParams(*inset_)) {
                        applyParamsToInset();
                }
        } else {
                applyParamsNoInset();
        }

Allan. (ARRae)