On Thursday 24 January 2002 8:30 pm, Juergen Spitzmueller wrote:
> Michael Schmitt wrote:
> > 1. If you create a table with a column of fixed width and
> >     then you declare one of the cells in this column as a
> >     multicolumn cell, the tabular dialog behaves incorrectly:
> >     The "H. Alignment" in the "cell" tab is always reset to
> >     "left" when you press "close" and reopen the dialog.
> >     I guess "pwidth" on line 200 in "FormTabular.C"
> >     is wrong. Could you please have a look at it?
> 
> No, the code is correct IMHO.
> I think it is not possible to set H. Alignment in a column with fixed 
> width, multicolumn cell or not. That's why it is reset to "left" (Jug, 
> please correct me if I'm wrong). What should be done to make this clear 
> is disable H. Align in "Cell" if a fixed width is chosen in column. 
> I've attached a patch.
> 
> > 2. While having a short look at the code, I noticed
> >     that lines 206-208 and 240-242 seem to be contradictory.
> 
> Why?

Well, lines 206-208 are redundant. Fixed.

> > 3. In the tabular dialog ("Column/Row" and "cell" tabs)
> >     different types of buttons are used for "H" and "V" alignment.
> >     Shouldn't they look the same?
> 
> Of course :-) The patch changes this (if it is accepted as a "bugfix" 
> at this point of time).
> 
> Juergen

This seems to be a perfectly acceptable patch. I'll submit it.

Angus

Reply via email to