On Tuesday 19 February 2002 4:18 pm, John Levon wrote:
> On Tue, Feb 19, 2002 at 03:59:09PM +0000, Angus Leeming wrote:
>
> > I'd like to commit the attached patch.
>
> are you trying to confuse :)
>
> + if (pid<=0) { // Fork failed.
> + retval = 1;
Sorry, I don't follow you. We tried to fork and failed, so return an
indication of such to the function that invoked startscript. Why is that
confusing.
> please separate out the three cases after fork() !
> as it is the comment is dead wrong
You're being too cryptic for me. Don't follow you.
> + if (getpid() == 0) {
>
> please don't (man getpid) - it's just confusing to use the
> same name...
so you'd be happy with pid() here. Fair enough.
Angus
