>>>>> "Juergen" == Juergen Vigna <[EMAIL PROTECTED]> writes:
Juergen> I think it is better to have certain discussions on lyx-devel I think you can have lyx-devel in cc: of a bug. Juergen> From #213 buglist comments: #214, actually. >> Why would the url dialog not respond to edit on button 3, whereas >> others do? That will not fix anything... Juergen> I didn't propose that you (JMarc) did it in your earlier Juergen> comment I just picked that up and put it into a realization. Juergen> And it would fix it if we have this definintion as default Juergen> and would change it in all edit calls which open dialogs for Juergen> "editing" an inset! Sorry, which definition? I am a bit lost. >> Also, why are some actions done on buttonpress and others on >> buttonrelease? Juergen> Easy! How would you do a selection if the cursor position is Juergen> not set on a buttonpress? Not with button3, though. Juergen> On the other side most programms handle "button" presses on a Juergen> button release event. So that's the distinction. If we enter Juergen> a HE-Inset we have to do this on button-press, while on all Juergen> other type of insets (which normally only open a dialog) we Juergen> do that on button release. So in general all openening of Juergen> dialogs is done on the ButtonRelease event, while all cursor Juergen> setting events are done on a ButtonPress. Obviously if you Juergen> want to set the cursor inside a InsetText you have to lock it Juergen> first! I can understand that. Juergen> If you know some clever workaround for this just go on an Juergen> implement it or let us know how you would implement it. The problem is that we are mixing two action, which are 'edit' and 'properties' (as in right click menus of windows apps). For a normal editable inset, those two notions are the same, but they are different for collapsable insets, for example. Hmm, can you try to fix the following remark I had in the bug: - the reason why the insetminipage button opens is because InsetText::insetButtonRelease did not return true although it did open a popup It seems that in insettext.C:1018, since we unconditionally calls inset->edit(), we should set ret to true. Or maybe use some more convoluted logic (but I am not sure what has to be done). JMarc
