Michael, I'm a little surprised by the #includes in this file. Why do you
need to #include any of these:
#include "ControlBibitem.h"
#include "ControlBibtex.h"
#include "ControlCharacter.h"
#include "ControlCitation.h"
#include "ControlError.h"
#include "ControlInclude.h"
#include "ControlLog.h"
#include "ControlUrl.h"
#include "ControlVCLog.h"
#include "ControlTabularCreate.h"
#include "ControlERT.h"
They should all be in GUI.h which you already #include.
Also, you should really
#include "LyXView.h"
rather than
#include "BufferView.h"
since that's what you use!
Incidentally, did you resolve the problem you were having with spurious
signal emission?
Angus