On Thu, May 30, 2002 at 04:14:55PM +0200, Jean-Marc Lasgouttes wrote: > > >>>>> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > Martin> On Thu, May 30, 2002 at 11:31:56AM +0300, Martin Vermeer > Martin> wrote: ... > > >> The following script fixes my .lyx files after conversion to lyx > >> 1.2.0. I think this issue should be prominently announced, and > >> fixed *at the source* for 1.2.1 (or 1.2.0fix1?) > > Martin> The attached patch does the job for 1.2.0 tar -- very trivial > Martin> (did I miss something?). Please apply. > > Actually, it seems to me that Herbert's patch (which changes the > figinset compatibility code, as it should) is better. However, it also > introduces support for vertical %, and this certainly needs some > testing. Would you be willing to try out the patch at > http://www.mail-archive.com/[email protected]/msg38091.html > > However, something I do not see in Herbert's patch is where is the > code to output in latex \textheight and friends.
You don't need to see that, as text% -> \textheight was already OK.
> Martin, the part of the patch that solves your particular problem is,
> in insetgraphics.C:
>
> @@ -441,8 +437,10 @@
> // FormatVersion < 1.0 (LyX < 1.2)
> void InsetGraphics::readFigInset(LyXLex & lex)
> {
> - std::vector<string> const oldUnits =
> - getVectorFromString("pt,cm,in,p%,c%");
> + std::vector<string> const oldUnitsWidth =
> + getVectorFromString("pt, cm, in, text%, col%");
>
>
> Thanks.
>
> JMarc
Applied Herbert's patch and it works perfectly for my 300+ page doc.
So -- forget about my patch and go for this one.
Of course I have my own usage patterns that don't exercise the
vertical stuff at all.
Someone else should try the vertical stuff. Can this patch be
applied to current CVS or has history passed it by already?
Martin
msg38800/pgp00000.pgp
Description: PGP signature
