On Thu, Aug 01, 2002 at 12:17:08PM +0200, Jean-Marc Lasgouttes wrote:
> + Buffer * buffer = bufferlist.newFile(filename, "");
>
> I thought that the second argument to newFile was a bool.
Buffer * BufferList::newFile(string const & name, string tname, bool isNamed)
Though that obviously shows a little cleanup I can do :)
> Did you test what happens when one chooses a nonsensical file name
> (non-existing directory, for example) and then tries to save? Failing
> to save is OK, crashing lyx is not :)
I didn't test, but it works (with some ugliness but that's not
appropritate to fix for 1.2 because it's not a regression)
> Othrwise, I am OK in principle for this patch in 1.2.x.
OK
regards
john
--
"The simpler it is, the harder it is."
- Tim Van Holder
