[EMAIL PROTECTED] (Juergen Spitzmueller) writes:

| Lars Gullik Bjønnes wrote:
>> Then let's see the minimal patch for this problem again, please.
>
| OK, attached is a fresh patch. The change is really trivial, the biggest part 
| of the patch (in the ui-file) is the rearrangement of the widgets to fit the 
| LineEdit and the PushButton in.

Ok.

Add some spaces (++) and I am satisfied:

| +void QBibtexDialog::addPressed()
| +{
| +     QString file = addBibED->text();
             ^^^^^
           can this be const?

| +     if (!file.isNull()) {
| +             string const f = ChangeExtension(file.latin1(), "");
| +             bool present = false;
| +             for(unsigned int i = 0; i!=databaseLB->count(); i++) {
                                       ^^^^                    ^^^^^
                                       space              pre instead of post

| +                     if (databaseLB->text(i).latin1()==f)
                                                       ^^^^^
                                                        space

| +                             present = true;
| +
| +             }
| +             if (!present) {
| +                     databaseLB->insertItem(f.c_str());
| +                     form_->changed();
| +             }
| +     }
| +}

-- 
        Lgb

Reply via email to