On Thu, Jan 30, 2003 at 09:44:10PM +0000, Martin Craig wrote:
> OK, here's a patch to make the Gnome dialogs work again. I hope I've
> created it properly :-). It is just a straight port of what was there
> and doesn't add any new functionality (apart from one v. small bug fix).
>
> All feedback very gratefully received. I'll start taking a look at some
> of the other GUI classes when I get a chance.
Some comments :
1) your patch seems to introduce some changes in the standard header for
some reason ?
2) You remove some periods here :
- log_text()->get_buffer()->set_text(_("No build
log file found."));
+ log_text()->get_buffer()->set_text(_("No build
log file found"));
else
- log_text()->get_buffer()->set_text(_("No LaTeX
log file found."));
+ log_text()->get_buffer()->set_text(_("No LaTeX
log file found"));
why ?
3) lyx code doesn't look like this :
+GnomeBase::GnomeBase(string const & name)
+ : ViewBase()
+ , updating_(false)
+ , title_(name)
Try :
+GnomeBase::GnomeBase(string const & name)
+ : ViewBase(),
+ updating_(false),
+ title_(name)
4) You introduce spaces instead of a tab at one point
On the whole though, this patch looks good to me.
Note we won't consider it yet, because we are getting 1.3.0 out of the
door. Once that happens, we'll look at the patch again. OK ?
Also, it's probably worth talking with Walter and Michael about what
they've been doing.
thanks
john
