John Levon wrote:
> On Fri, Mar 07, 2003 at 07:05:05PM +0000, Angus Leeming wrote:
>
>> Actually, why do we perform this guess-work at all? Why not
>
> It's not guesswork.
Bullshit.
string const name = lyxaction.getActionName(ev.action);
if (!ev.argument.empty())
xpm_name = subst(name + ' ' + ev.argument, ' ','_');
else
xpm_name = name;
This is totally unnecessary jiggery-pokery. Moreover, it leads to a pixmap
filename in the above case of
dialog-show-new-inset_graphics.xpm
which merely highlights that we'd need to rename our pixmaps anytime we
change the lfun names.
>> Icon "dialog-show-new-inset graphics" "graphics.xpm"
>
> Why ?
Because it's three lines of code and it's done in ToolbarDefaults.C (which,
as you note, is where this code should be). Shall I do it?
--
Angus
