On Wed, Mar 19, 2003 at 10:14:24AM +0100, Jean-Marc Lasgouttes wrote:

> Did you actually check in each case that the readonly status of the
> lfun was compatible with the CHANGE flag used in the corresponding
> update() call? An example I had in mind (although it may be fixed
> with Angus latest dialog work) is the various layout dialogs. You can
> bring them up in a RO document, but in general they have the potential
> to modify the document.

Indeed, Angus' work was very helpful, but even so, it's simply a matter
of chedcking the apply() methods of the controllers. Anything that goes
directly is suspect, and may need special handling (I've mentioned the
cases I've found already). But most of them go through LFUNs
(TABULAR_FEATURE, INSET_APPLY) anyway. It seems to work OK for me

Actually, I've just found that the Character dialog has this problem.
But that's a bug anyway, in LyXAction.C (the change goes through another
LFUN, so it's OK)

regards
john

Reply via email to