> As dispatched() now returns a bool, why not rename it as success()?
> The code above is then very elegant.
[...]
> Staying on the subject of names:
> if (result.val() == FINISHED) {
>
> why not rename val() as status()?
> if (dispatch.status() == FINISHED) {

Just by looking at the proposed change, I second Angus. It sounds better and I 
admit if I were to start working on that source, I would catch meaning of 
status() and success() immediately, while val() is very cryptic and 
dispatched() only slightly less so.

Just an independent opinion in our opinionated world :)

Cheers, Kuba

Reply via email to