On Mon, Nov 03, 2003 at 02:25:38PM +0000, Jose' Matos wrote:
> On Monday 03 November 2003 13:02, Andre Poenitz wrote:
> > On Fri, Oct 31, 2003 at 04:21:55PM +0000, Jose' Matos wrote:
> > > The attached patch unifies the API used for the different backends in
> > > insets.
> > >
> > > In inset.h we have:
> > >
> > > int latex(Buffer const &, std::ostream &,LatexRunParams const &);
> > > int ascii(Buffer const &, std::ostream &,LatexRunParams const &);
> > > int linuxdoc(Buffer const &, std::ostream &,LatexRunParams const &);
> > > int docbook(Buffer const &, std::ostream &,LatexRunParams const &);
> > >
> > >   that is, we use the LatexRunParams to carry the different running
> > > parameters.
> >
> > [Why not move the Buffer ref to LatexRunParams as well?]
> 
>    If you have included files the buffer ref will change, but actually the 
> ostream is the same all over the same run.
> 
>    We can put those two variables over there, and have a single argument, but 
> I don't think that gain us anything.

Not much indeed. But the interface is a bit leaner, the rgument is
hardly ever used, passing two structs is marginally faster than passig
three... some small benefits without too much of a disadvantage...

Andre'

Reply via email to