Angus Leeming wrote: > Alfredo Braunstein wrote: > >> I've removed all inset-dependent fitCursor functions, >> and put toghether all fitcursor-related functions in screen.C in >> only one, putting the smart tall row handling there (with some code >> simplification and nice variable names). >> >> Now the same routine is used for mathed and normal cursors, and this >> is achieved by adding a LCursor::getDim(int & asc, int & desc), that >> handles by itself cursors in LyXTexts and eventually asks the inset >> (in fact, only for math insets). >> All the cmputations in fitCursor are done with this dimension. >> >> Comments (and/or testing vs. 1.3.x) greatly appreciated. > > No time to test, but this looks excellent to me.
Thanks! > Wht the FIXME? > Index: mathed/formulabase.h > + /// FIXME > + virtual void getCursorDim(BufferView *, int &, int &) const; > ;-) Cut & paste from the function below. Should I add the description or it's not needed for virtuals? The base one in updatableinset.h *does* have the comment. Alfredo
