On Wed, Nov 19, 2003 at 09:20:15AM +0000, Angus Leeming wrote:
> Alfredo Braunstein wrote:
>
> Index: lyxtext.h
> + struct Pos {
> + int x;
> + int y;
> +};
> No default constructor to initialize these two? Brave man!
>
> + Pos pos_;
> If it's public, you can get rid of the trailing underscore.
> Tell the world what 'pos_' is. Give it a nice little comment.
>
>
> Index: text2.C
> +{
> + pos_.x = 0;
> + pos_.y = 0;
> +}
> Ah-haa! struct Pos does indeed need a default constructor!A
I'd actually prefer here simply int xo_ and yo_ as this is what's used
both in insets/* and mathed/* for the same purpose.
[I know, usually I'm the one who puts stuff in a single 'parameter
struct'..]
> Do you plan to go to absolute coordinates for everything? The stuff
> below is a horrible mix of the two...
I recall Alfredo saying 'small steps towards absolute coords'.
Andre'
--
Those who desire to give up Freedom in order to gain Security, will not have,
nor do they deserve, either one. (T. Jefferson or B. Franklin or both...)
