On Wed, Dec 10, 2003 at 02:49:15PM +0000, Angus Leeming wrote:
> No need to pass the 'name' to each instance of InsetNoteMailer,
> InsetBranchMailer as this name is fixed for each Mailer type.
>
> Committing now.
Concerning
-string const InsetBranchMailer::params2string(string const & name,
- InsetBranchParams const &
params)
+string const InsetBranchMailer::params2string(InsetBranchParams const &
params)
{
ostringstream data;
- data << name << ' ';
+ data << name_ << ' ';
params.write(data);
// Add all_branches parameter to data:
data << params.branchlist.allBranches() <<
"\n";
Have you considered changing that params2string interface to
void InsetBranchMailer::params2string(InsetBranchParams const &,
ostream & data)
{
data << name << ' ';
data << name_ << ' ';
params.write(data);
// Add all_branches parameter to data:
data << params.branchlist.allBranches() << "\n";
}
(or when we are at it even
ostream & InsetBranchMailer::operator<<(ostream & os,
InsetBranchParams const &)
{
os << name << ' ';
os << name_ << ' ';
params.write(os);
// Add all_branches parameter to data:
os << params.branchlist.allBranches() << "\n";
return os;
}
one concept less to grasp and even better re-usable...)
Andre'
