On Fri, Dec 12, 2003 at 04:23:57PM +0000, Angus Leeming spake thusly: > > Martin Vermeer wrote: > > OK. 1 is just verifying if you can remove it, 2 is tricky but should > > be possible (thorough testing!) 3: go right ahead if you think it is > > The Right Thing. 4. ... testing needed. I suspect colour lookup > > table refresh/caching (is there still such a thing?) > > Patch attached addresses points 1-3 and results in MUCH simpler code > although it shaves the total number of lines down by 30 only. > > I'll hold off applying it to give you some chance to test it out > yourself. Seems polite ;-) > > -- > Angus
Thanks... unfortunately I'll have no time this weekend or next week to do this. So don't wait for me. The changes look OK as far as I can judge. (Some things I wanted to do also, like the BranchList API streamlining. I still find myself writing Microsoft Basic even under the guise of C++). Please make sure that it all works especially borderline cases (forgetting to define a colour for a branch... saving/loading docs containing branches... exiting and re-entering the dialog... you know the drill :-) - Martin
pgp00000.pgp
Description: PGP signature
