Georg Baum wrote:
> Juergen Spitzmueller wrote:
> > BTW: I found some problems with the External dialog.
> > 1. Scaling did not work with xfig images, because
> > \scalebox{<horizontal>}{<verical>}{<content>}
> > was used instead of the correct
> > \scalebox{<horizontal>}[<verical>]{<content>}
> > (2. arg is optional). This one gets fixed by the patch.
>
> Did you check wether this is for an old version of the scalebox command? I
> can't imagine that this was broken.
No, this is the definition that scalebox always had (to my best knowledge). I
suspect LyX was indeed broken from the beginning (and the one who implemented
it mixed scalebox and resizebox).
> > 2. Raster images do not get converted -> LaTeX error (Including a png
> > image via the External dialog also fails in 1.3)
> > No idea how to fix this.
>
> I don't understand. Do you mean that if the conversion fails you get a
> latex error, or do you mean that the conversion fails always?
Conversion fails always. LaTeX is complaining about a missing *.eps file
(pdflatex about missing pdf files). In 1.3, there's the additional error that
\usepackage{graphics} is not added to the preamble.
OTOH I do not wonder that nobody noticed this. Who uses the external inset to
insert files which can also be inserted via the graphics dialog?
> Why did you change insetexternal? I am not sure if things like
>
> > �bool ResizeData::usingScale() const
> > �{
> > - return !float_equal(scale, 0.0, 0.05);
> > + return (!scale.empty() && scale != "0");
> > �}
>
> work.
Look at the archives for the threads "float2string" and "validators for the
rest". tostr(float) -- i.e. boost::lexical_cast -- is broken and Lars
strongly argued for never storing float values internally, but strings (and
LyXLengths). We had a longer discussion (mostly JMarc and Lars) and decided
to go this way. So I am inbetween the process of changing all occurences of
floats to strings. Some work has already been applied.
> > + float rotAngle = strToDbl(angle);
>
> Why not double?
Why double? Float is sufficient for this value.
J�rgen
> Georg
