Angus Leeming <[EMAIL PROTECTED]> writes:
| Lars Gullik Bj�nnes wrote:
>> This is what it looks like simplifed and rewritten to use
>> boost.filesystem.
>> I have not changed the visual apparence of the dialog, so there are
>> one widget too many on it currently (unused).
>> Please comment.
>
| What's to comment? Fantastic! The existing code is a pile of ancient,
| fossilized poo. Of interest to paleoentologists but crap to the rest
| of us. Anything you do to simplify the code is a good think. IMO.
I have another patch as well now... one that removes FileInfo
completely. I'll post that after making a test compile and lookint it over.
btw. We have lots and lots of filesystem-race conditions. Most often
these does not matter much, but we should plan to get rid of them...
fs::exists(foo) && fs::is_directory(foo) is actually racy and can
result in an unwanted exeption since foo can have been deleted between
the call to exists and the call to is_directory.
--
Lgb
