On Mon, May 02, 2005 at 07:00:05PM +0200, Georg Baum wrote:
> Martin Vermeer wrote:
> 
> > On Mon, May 02, 2005 at 03:25:39PM +0200, Juergen Spitzmueller wrote:
> >> I kind of like the idea (untested), but I think you should trigger an
> >> Alert which tells the user that some charstyle insets haven't been found
> >> etc.
> > 
> > Unfortunately that's not easy to do under this approach... you don't
> > know it happened until after you saved and re-loaded. That's precisely
> > the weakness of this approach.
> 
> It is easy. Proof attached (replaces your patch). This is a case where the
> dociterator stuff pays off. And I found a missing _() as well.
> I think this should go in if it works for you, too (I have not tested it
> thoroughly).
> 
> 
> Georg

Tested and works great. Just put it in.

It would be possible, at the cost of a little spaghetti, to allow the
"Undef: CharStyle" insets to revert to "CharStyle" if the textclass is
reset to one that contains its definition. Just chop off the "Undef: "
prefix inside LyXTextClass::charstyle(). But would it be really worth it?

- Martin

Attachment: pgpNmMV8hIeN4.pgp
Description: PGP signature

Reply via email to