On Thursday 12 May 2005 13:13, Angus Leeming wrote: > I don't know anything about this stuff either, but looking at the code I > have a couple of questions: > > Given that "*e->text().ascii()" is a char, why do you need the > static_cast<int> ? Surely, C++'s type promotion rules will do that for > you?
Probably because explicit casts are cool. ;-) No reason I have simply decided to play safe. :-) > Why do you not inspect the keyboad modifiers (shift, cntl, alt) when > passing state==0? I thought about it for second, yes. But I don't know how to do that. :-) > Finally, given that you keep typeing "e->text()" wouldn't life be easier > with: > � � QString const & text = e->text(); > ? I agree. But I would expect to have a more general way since we are repeating this all over the place. > Incidentally, have you asked in the immodule list about this stuff? > (Given that none of us "know anything about this stuff either".) Sure not, real men don't ask questions they jump the cliff. ;-) I have noticed that its mailing has been really quiet lately. I will ask there and I will hope they don't laugh me. :-) > -- > Angus -- Jos� Ab�lio
