Jean-Marc Lasgouttes wrote:
Jean-Marc> What the patch does is to implement a better (?)
Jean-Marc> ControlSpellchecker::updateSlot(). Angus, I would really
Jean-Marc> appreciate if you could look at this.
Angus? I'd really like to understand what the intent of this API is,
to see whether it is used correctly.
Sorry, JMarc. I've been lost in the depths of Windows Installer land, for
which I blame you entirely :-P
Looking at the patch, shouldn't updateSlot() be:
+void ControlSpellchecker::updateSlot(bool switched)
+{
+ if (switched)
+ hide();
+ else
+ update();
+}
Other than that, it appears fine.
Sheesh! I'm glad I rewrote all this stuff!
Angus
