On Thu, 2005-12-22 at 12:48 +0100, Jean-Marc Lasgouttes wrote:
> >>>>> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
> 
> Martin> Jean-Marc, I think it is safe to assume that we do not want
> Martin> *this* in 1.4.0... what about the limited patch, with a better
> Martin> signature?
> 
> Yes, it looks a bit too complicated for now :)
> 
> I think singlerow4+fixes+signature would be OK.
> 
> Concerning the signature, we should leverage boost::crc32. Two ideas
> of text to compute against:
> 
> - the easy one: take the text of the row (including META_INSET
>   characters) as a string to compute the crc on, and add the y
>   information somehow (we could maybe keep a <crc,y> pair as
>   signature). This is crude, but uniformly better than what we have.

Is crc32 invariant for character transposition?

> - the expensive one: generate the .lyx format code to the range in the
>   row (the changes to lyx writing code to make this happen are
>   hopefully small) and compute crc on this. This may prove less expensive
>   than it seems :) Of course, in a world where we hope to be able to
>   update insets without updating the hosting row, it will redraw too
>   much.

Or use the width of the whole row. *Very* likely to change if the inset
gets written into (OK, not perfect)

> - an alternative in the middle would be to replace the META_INSET
>   chars by a string (like "[12,32]") describing the dimension of the
>   inset.

Yes, that's an option too.

I'd like to keep it simple though, remember it is only cosmetic.

- Martin

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to