Angus Leeming a écrit :
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
Just some little observations.
Angus
/// Copy constructor.
RandomAccessList(RandomAccessList const & ext_list) {
- for (const_iterator it = ext_list.begin();
- it != ext_list.end(); ++it)
+ // Don't recompute end on each iteration of the loop.
I thought the compiler would take care of that. If not, of course you're
right.
/**
- \todo This could be optimized a bit by rebuilding ItVector
- instead of multiple deletion.
+ TODO: use std::remove_if and vector<>::erase, passing the
You don't like '\todo'? Doxygen recognize it and generates a nice TODO list.
+ same predicate to remove_if as is used by erase(size_t);
+ Refactor the other erase() member funtions to use this predicate
+ also?
To be investigated...
Thanks,
Abdel.
