>>>>> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:
Abdelrazak> Fine! Then I'll commit it to 1.5 if nobody object. If
Abdelrazak> somebody want to object, speak now please.
If it is still time, I have a few comments:
- I like the setItemLabel separation (and the setEnumLabel in the
other patch) as a general cleanup. setCounter should probably be
renamed to setLabel or setParLabel.
- there are many easy cases you do not account for in needsUpdateCounters.
Actually, I think you should always return false when
current_par.layout().counter is empty. In this case, you should just
invoke setCounter on this paragraph and return false. No more
special casing.
bool needsUpdateCounters(Buffer const & buf, ParIterator & it)
{
if (it->layout()->counter.empty()) {
setCounter(buf, it);
return false;
}
// do more things with enumerate later
return true;
}
- I like very much the proposal of having counter-enabled paragraphs
register themselves in a special structure.
JMarc
