Martin Vermeer a écrit :
On Tue, 2006-04-25 at 12:04 +0200, Abdelrazak Younes wrote:
Martin Vermeer a écrit :
On Tue, 2006-04-25 at 10:40 +0200, Jean-Marc Lasgouttes wrote:
"Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
Martin> Should be straightforward. What about
Martin> LFUN_OUTLINE_{UP|DOWN|IN|OUT}? For now.
Sure why not.
Martin> To make sure we have a valid cursor after the doc change?
That is probably true indeed.
Most of your suggestions for sanitation are done in the attached patch,
which I propose for trunk, for now.
Just a little note Martin. You use a switch case at three or four
location for outline operations; you could as well split the
"toc.C:outline()" function into four (moveUp, moveDown, moveIn and
moveOut) so that they could be extended in the future for enumeration
and list.
But that would lead to quite some duplication of code.
Are you sure? The switch cases in toc::outline() seems pretty
self-contained for me. And you will get rid of all other switch statements.
And I don't think
the present situation prevents extending in that way.
Sure but I not am sure "outline" is the correct name for manipulating
lists (I may be wrong though), moveXX seems more intuitive.
This is not very important anyway, your code is just fine the way it is :-).
Abdel.
