>>>>> "Bo" == Bo Peng <[EMAIL PROTECTED]> writes:

Bo> Dear list, We have had a long discussion regarding this auto view
Bo> business. Here is my second offer:

Bo> 1. apply the attached patch. This is a slightly modified version
Bo> of my patch + Enrico's cygwin stuff.

The src/ part of the patch looks good (at least to me). What I am not
sure about is whether the "edit" verb really exists for all windows
apps and whether we should revert to "open" if it fails.

Anyway, I think autoOpenFile should not be passed a verb as string
(which is really a windows-only think) but rather a bool or an enum.

Bo> With this patch, viewer for pdf/ps will be handled to windows
Bo> *completely*. When ghostview is not installed, and the menu item
Bo> is chosen, the standard 'choose a program' dialog will appear and
Bo> ask the user to install a viewer.

Bo> 2. I somehow agree with JMarc that this behavior is not optimal
Bo> (although far better than the current situation). Choosing from
Bo> removing this view->ps or disablong it, I obviously choose the
Bo> latter. 

I could agree on that if there are not too many of these removed
entities. As I said, the Send To menu is the only think I know in
windows which is similar to what we want.

Bo> However, searching for ghostview is *completely wrong*. A viewer
Bo> under windows should be checked through registry, and we should
Bo> not check for a specific program. I am searching around, and will
Bo> provide a patch that disable this menu item when no viewer is
Bo> linked to ps format (and to pdf).

I definitely agree with it and it is my point with proposing to
replace configure.py output with "auto" for all formats that seem to
be supported by windows. This should be done in LyX itself, so that
reconfiguration is not necessary.

For the reasons above, I do not like the configure.py part of your
patch. 

Bo> Can I commit?

Not yet please. I really prefer to see the patch (since anyway I
comment mostly on the approach).

JMarc

Reply via email to