Abdelrazak Younes wrote: > Perhaps but please look at the actual patch before making a decision. I > am almost certain that this include is not needed at all. So a simpler > patch would be to just erase them. "qttableview" in qt3 is some code > stolen for Qt2 source code, it is not used at all in qt4 (replaced with > QTableWidget IIRC).
Jean-Marcs concern is still valid: If the include is not needed, remove it. Simply replacing it by something else that is not needed either does not make sense. And if the include is needed leave it like it is. The c-prefixed variants are not available everywhere. > Keeping a test for something we don't use is wrong IMHO. 100% ACK. If you want to cleanup these things: A good start would be the remaining OS/2-related bits (lots of EMX ifdefs). > Then, if a need > for this is coming back in the future, we should use a _portable_ header. I don't agree. It may look strange, but as others pointed out limits.h is actually more portable than climits. Georg
