>>>>> "Bo" == Bo Peng <[EMAIL PROTECTED]> writes:
Bo> JMarc, What do you think about the attached patch? It will allow Bo> lyx to compile with MSVC2003/2005. I know that lyx has been Bo> working with msvc before and I am not sure what autotools have Bo> done to walk around these. Is that for 1.4 or 1.5? Bo> Index: src/frontends/qt4/BulletsModule.C Bo> Abdel said that this is OK to him. OK. Bo> Index: src/support/lyxsum.C Bo> ifstream is needed for both cases (with/without Bo> HAVE_DECL_ISTREAMBUF_ITERATOR) OK. Bo> Index: src/support/tempname.C Bo> As far as I know, IRUSR and S_IREAD etc are identical. Yes. This is OK. Bo> Index: src/support/forkedcall.C Bo> I have checked mingw/cygwin/msvc, cerrno exists, but I can not Bo> check gcc prior to 3.4.3. If you want to make sure, I can do a Bo> HAVE_CERRNO test. I do not know much about this, but I guess it will do. It only matters in windows anyway, so I trust your testing. Bo> Index: src/support/mkdir.C Bo> mkdir is defined in direct.h, which I will test in scons. OK. Bo> Index: src/support/package.C.in Bo> PATH_MAX deos not always exist. I am not sure the value 512 is good. In ./boost/regex/v4/fileiter.hpp, it is set to 256 and this admittedly not authoritative page http://www.codecomments.com/archive272-2004-9-286081.html says: According to MSDN, on Windows, MAX_PATH is 260 characters, and so is FILENAME_MAX. JMarc
