You can read about conventions in the GNU make manual
http://www.sunsite.ualberta.ca/Documentation/Gnu/GNUinfo/html_node/standards_46.html
http://www.sunsite.ualberta.ca/Documentation/Gnu/GNUinfo/html_node/standards_47.html

Many unix administrator rely on these variable having kept this
meaning for the last 30 years, I guess. You can decide to scrap that,
of course :)

Thank you very much for the link. I, however, do not see the scary
scenario of CCFLAGS replace something while CPPFLAGS add to it. All I
can see is

1. if some flags are essential, hard-code them
2. if some flags are optional, keep them as default for CCFLAGS etc
3. setting of CCFLAGS etc will always replace the default values.

Currently, scons set 1,2 both as default, and append 3. I will change
to the make behavior which is more reasonable.

BTW, can the attached patch go in (1.4.xsvn)? The only benefit is that
current 1.5 scons can compile 1.4.x without having to add this macro,
but this test is unnecessary anyway.

Cheers,
Bo
Index: src/support/gzstream.h
===================================================================
--- src/support/gzstream.h	(revision 14098)
+++ src/support/gzstream.h	(working copy)
@@ -32,9 +32,7 @@
 // standard C++ with new header file names and std:: namespace
 #include <iostream>
 #include <fstream>
-#ifdef HAVE_ZLIB_H
-# include <zlib.h>
-#endif
+#include <zlib.h>
 
 // For LyX
 #define GZSTREAM_NAMESPACE gz
Index: src/support/ChangeLog
===================================================================
--- src/support/ChangeLog	(revision 14098)
+++ src/support/ChangeLog	(working copy)
@@ -1,3 +1,6 @@
+2006-06-14  Bo Peng <[EMAIL PROTECTED]>
+	* gzstream.h: remove unnecessary test for HAVE_ZLIB_H
+
 2006-05-29  Jean-Marc Lasgouttes  <[EMAIL PROTECTED]>
 
 	* os_unix.C (canAutoOpenFile, autoOpenFile): add support for Mac

Reply via email to