Lars Gullik Bjønnes wrote:
Abdelrazak Younes <[EMAIL PROTECTED]> writes:

| Lars Gullik Bjønnes wrote:
| > Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| > | Hello,
| > | | One more brick to the wall: 16/17 seconds for UserGuide now.
| > This has to be checked/fixed on xform/gtk/qt3 as well.
| | I know and I am afraid of the work involved in fixing them. Could we
| take a decision on xforms at least?

I'd like to see at least this patch be done for xforms as well, just
for the sake of testing its speed. I have no strong feeling about
xforms, especially if we can show that qt3/qt4 can operate and approx.
the same speed.

I don't think you will see a speed advantage for xforms. The updateScrollbar() calls are expensive but not that much compared to the signal/slot communication involved when touching the scrollbar. My first patch disabled the signal emission in GuiWorkArea::update() by calling "verticalScrollBar()->setTracking(false);"

I have to check if the same cleanup can be done in qt3. But it's a bit more complicated there because of the QContenPane/QWorkArea split.


| > (and the code deleted not just commented out)
| | I've let them for now in the eventual case where someone finds a hole
| in my srollbar code cleanup. I don't think there's any but who
| knows... I'll delete the code before merging to trunk anyway.

Please, either a separate branch for this one or directly to trunk.
Then I'll even help you fix xforms.

I'll see what I can do.

Abdel.



Reply via email to