"Bo Peng" <[EMAIL PROTECTED]> writes:

| Sorry Georg, it is too complicated to apply your patch. I guess you
| can simply commit.
| 
|               { LFUN_CHAR_FORWARD_SELECT, "forward-select", ReadOnly | 
SingleParUpdate },
| +             { LFUN_CLIPBOARD_PASTE, "clipboard-paste", Noop },
| 
| For C-v or menu paste only, right?
| 
| +     case LFUN_CLIPBOARD_PASTE:
|       case LFUN_PRIMARY_SELECTION_PASTE: {
| -             string const clip = cur.bv().owner()->gui().clipboard().get();
| +             string const clip = (cmd.action == LFUN_CLIPBOARD_PASTE) ?
| +                     cur.bv().owner()->gui().clipboard().get() :
| +                     cur.bv().owner()->gui().selection().get();
| 
| Why don't we handle these two actions separately? My understanding
| is that the first should be triggered by C-v, the second by
| middle-button.

Only on windows... on linux (with emacs bindings) C-y will yank from
selection., but also from clipboard... depends really...
  +     case LFUN_CLIPBOARD_PASTE:
|       case LFUN_PRIMARY_SELECTION_PASTE: {
|               cur.clearSelection();
| -             string const clip = bv->owner()->gui().clipboard().get();
| +             string const clip = (cmd.action == LFUN_CLIPBOARD_PASTE) ?
| +                     bv->owner()->gui().clipboard().get() :
| +                     bv->owner()->gui().selection().get();
| 
| If the body is not long, I still prefer separating these two
| actions, rather than telling them apart from cmd.action.

I might even agree...
 
-- 
        Lgb

Reply via email to