On 3/25/20 10:27 AM, Ken Pettit wrote:
Hey Guys,
Okay, I have fixed this bug (in src/file.cpp). The de-tokenizer was
not testing for quoted strings. I pushed the changes to the git repo
here if anyone wants to pull it and compile prior to an official VT
1.8 release:
git clone https://git.code.sf.net/p/virtualt/code virtualt
Ken
Don't you get a lot of these generated by your compiler?
This is just a couple out of many from a fresh git pull.
I didn't find these myself before, I just addressed each compiler
warning until there weren't any more.
I'll go through them again and see if sourceforge provides a way to
submit patches back up like gitlab or github.
src/m100emu.c: In function ‘check_installation’:
src/m100emu.c:723:39: warning: ‘%s’ directive writing up to 255 bytes
into a region of size 240 [-Wformat-overflow=]
723 | sprintf(localpath, "No ROM file for %s", errors);
| ^~ ~~~~~~
In file included from /usr/include/stdio.h:867,
from src/m100emu.c:32:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:36:10: note:
‘__builtin___sprintf_chk’ output between 17 and 272 bytes into a
destination of size 256
36 | return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
37 | __bos (__s), __fmt, __va_arg_pack ());
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
I also get this, which is probably from me using the latest fltk.
But the changes I made for that apparently didn't break building with
the older versions since Keven Becker said he just used the distro
supplied package.
Linking virtualt
/usr/bin/ld: obj/remote.o: in function `key_delay()':
remote.cpp:(.text+0x8f7): undefined reference to `fl_wait(double)'
/usr/bin/ld: remote.cpp:(.text+0x927): undefined reference to
`fl_wait(double)'
/usr/bin/ld: obj/remote.o: in function `cmd_step(ServerSocket&,
std::__cxx11::basic_string<char, std::char_traits<char>,
std::allocator<char> >&)':
remote.cpp:(.text+0x3279): undefined reference to `fl_wait(double)'
/usr/bin/ld: obj/remote.o: in function `cmd_step_over(ServerSocket&,
std::__cxx11::basic_string<char, std::char_traits<char>,
std::allocator<char> >&)':
remote.cpp:(.text+0x3577): undefined reference to `fl_wait(double)'
/usr/bin/ld: remote.cpp:(.text+0x3639): undefined reference to
`fl_wait(double)'
/usr/bin/ld: obj/remote.o:remote.cpp:(.text+0xb066): more undefined
references to `fl_wait(double)' follow
collect2: error: ld returned 1 exit status
make: *** [GNUmakefile:124: virtualt] Error 1
Assuming sourceforge provides a way to submit merge requests I'll do
that shortly.
--
bkw
