Actually that was true in JBoss Tools, but I removed that. The presence of a faces-config.xml file is what triggers the JSF activation on an application server. So I figured I might as well follow that rule. Moreover, the hardcoded dependencies detection was really ugly.
On Fri, Dec 7, 2012 at 7:53 AM, Max Rydahl Andersen <[email protected] > wrote: > > Fred, > > > > For the JSF configurator, what happens in the case where there is no > faces-config.xml and no JSF configuration in web.xml? No JSF facet > installed? > > The JSF facet is currently looking for a mix of dependencies and info in > faces-config.xml decide wether or not JSF is enabled - see > https://github.com/jbosstools/jbosstools-central/blob/master/maven/plugins/org.jboss.tools.maven.jsf/src/org/jboss/tools/maven/jsf/configurators/JSFProjectConfigurator.java#L329 > > and > > > https://github.com/jbosstools/jbosstools-central/blob/master/maven/plugins/org.jboss.tools.maven.jsf/src/org/jboss/tools/maven/jsf/configurators/JSFUtils.java#L148 > > If none of these are fulfilled then yes, JSF facet will have to enabled > explicitly. > > /max > > > > > Thanks, > > - Ian > > > > From: Fred Bricon [mailto:[email protected]] > > Sent: Thursday, December 06, 2012 1:59 PM > > To: General discussion of project-wide or architectural issues. > > Subject: Re: [wtp-dev] New m2e JavaEE configurators from JBoss Tools > (minus JPA) > > > > Dev call minutes available at : > http://wiki.eclipse.org/M2E-WTP_DEV_MEETINGS#06.2F12.2F2012 > > > > If you think I forgot something or see any errors, please don't hesitate > to edit the page. > > > > Regards, > > > > Fred Bricon > > > > On Wed, Dec 5, 2012 at 3:49 PM, Neil Hauge <[email protected]> > wrote: > > Fred, > > > > It's great to here of the contribution and the progress you are making. > One thing we can talk about on the call is starting to align m2e-wtp with > the WTP schedule. As what I hope becomes a part of the larger WTP > offering, we will likely need to get m2e-wtp aligned with the general WTP > release schedule. This will ideally involve offerings for the yearly > simultaneous release, as well as specific maintenance releases to support > the SR's. Having an active maintenance stream and a dev stream for the > next major release is part of the standard process, and is necessary for > the stability of the released codebase. > > > > As a result, I would think that 0.17.0 should be an Eclipse Juno based > release, and should not be concerned with the Kepler code base at this > time. I understand that this may not be possible yet, but we can discuss > on the proposed call. > > > > This is part of the consequences/trade-offs of Dali's evolving > provisional API. There are many benefits, but also a cost. The Dali team > is ready to assist in any provisional API migration when the need arises. > I also planned to notify of these changes on milestones on > [email protected] but have missed the last two milestones. Tune into > dali-dev for additional change notification. For what it is worth, my > intention is that the Kepler release will be the last major evolution of > the provisional API's. > > > > Neil > > > > > > > > > > > > > > On 12/4/2012 3:56 PM, Fred Bricon wrote: > > Hi, > > > > earlier today I submitted JBoss Tools' JAXRS, JSF and JPA m2e project > configurators as a new contribution to m2e-wtp [1][2]. > > I cleaned up the original code, using the org.eclipse.m2e.wtp namespace. > The 3 configurators come as 3 separate, optional features to m2e-wtp. > > Hopefully, the contribution is IP clean so I'm expecting it'll be vetted > rapidly by the EMO team. > > > > All was good and well until, right before I submitted the code > contribution, I tested my local build against Kepler (JBoss Tools hasn't > started migrating to Kepler yet). > > Turns out the JPA configurator contribution is unusable without major > modifications, due to Dali breaking pretty much *all* the provisional API > JBoss Tools depended upon [3]. > > It's certainly my fault if I wasn't aware of the breaking changes > earlier. Well, I understand provisional API means it can be broken from one > minor version to another, but still, I think > > it would have been less painful if the code was marked as deprecated > instead, for at least 1 version increment. > > > > I really, really don't want to maintain several maintenance streams so, > it looks like the JPA support won't be made available until after we > release m2e-wtp 0.17.0 in february. > > > > I propose we discuss the subject and Kepler M4 this Thursday Dec 6th > (I'll be unavailable friday and the following week), at 11am-12am EST / > 17pm-18pm CET on a status call > > > > [1] https://dev.eclipse.org/ipzilla/show_bug.cgi?id=6934 (requires > IPZilla access) > > [2] https://bugs.eclipse.org/bugs/show_bug.cgi?id=395694 > > [3] > http://wiki.eclipse.org/New_Help_for_Old_Friends_VIII#JPA_Core_.28Provisional_API.29 > > > > Regards, > > > > Fred Bricon > > > > PS : Here are the details for the call : > > > > Reservationless-Plus Std International Dial-In Number:+44 (0) 2035 > 746870 > > > > Conference code: > > 7689927039 > > > > Global Dial In Numbers > > Argentina > > 08004441016 > > Australia > > 1800337169 > > Austria > > 0800005898 > > Bahamas > > 18002054778 > > Bahrain > > 80004377 > > Barbados > > 18668556594 > > Belarus > > 882000110160 > > Belgium > > 080048325 > > Bolivia > > 800100768 > > Brazil > > 08008921002 > > Bulgaria > > 008001100236 > > Chile > > 800370228 > > Colombia > > 018005182186 > > Costa Rica > > 08000131048 > > Croatia (Hrvatska) > > 0800222320 > > Cyprus > > 80095297 > > Czech Republic > > 800701035 > > Czech Republic, Mobile > > 800884448 > > Denmark > > 80887114 > > Dominican Republic > > 18007519076 > > Ecuador > > 1800020545 > > Egypt, *SITF* > > 08000000188 > > El Salvador > > 8006699 > > Estonia > > 8000100232 > > Fiji > > 008002539 > > Finland > > 0800117116 > > France > > 0805632867 > > Germany > > 08006647541 > > Greece > > 00800127562 > > Guam > > 18773010136 > > Hong Kong > > 800930349 > > Hungary > > 0680014726 > > Iceland > > 8008967 > > India, BSNL & MTNL > > 0008006103255 > > India > > 180030104350 > > Indonesia, PT Telkom only > > 0078030179162 > > Indonesia, PT Indosat only > > 0018030179162 > > Ireland > > 1800932401 > > Israel > > 1809462557 > > Italy > > 800985897 > > Jamaica > > 18002050328 > > Japan > > 00531250120 > > Japan > > 0120934453 > > Kazakhstan > > 88003337376 > > Korea (South) > > 007986517393 > > Latvia > > 80003339 > > Lithuania > > 880031223 > > Luxembourg > > 80026595 > > Malaysia > > 1800814451 > > Malta > > 80062176 > > Mexico > > 018009269658 > > Monaco > > 80093642 > > Netherlands > > 08000222329 > > New Zealand > > 0800888167 > > Nicaragua > > 0018002202067 > > Norway > > 80013504 > > Panama > > 0018002043574 > > Peru > > 080052972 > > Philippines > > 180011100991 > > Poland > > 008001210187 > > Portugal > > 800814625 > > Romania > > 0800895537 > > Russian Federation > > 81080028341012 > > Saint Kitts and Nevis > > 18002059252 > > Saudi Arabia > > 8008445917 > > Singapore > > 8006162235 > > Slovak Republic > > 0800001441 > > Slovenia > > 080080471 > > South Africa > > 0800982957 > > Spain > > 800300524 > > Sweden > > 0200896860 > > Switzerland > > 0800650077 > > Taiwan > > 00801127141 > > Thailand > > 001800656966 > > Trinidad and Tobago > > 18002024615 > > Turkey > > 0080044632093 > > Turks and Caicos Islands > > 18772780472 > > Ukraine > > 0800500152 > > United Arab Emirates > > 8000440163 > > United Kingdom > > 08006948057 > > United States > > 8004518679 > > Uruguay > > 00040190315 > > Venezuela > > 8001627182 > > Vietnam > > 12011346 > > Virgin Islands (U.S.) > > 8773007428 > > Global Dial In Numbers > > Australia, Adelaide > > 0870020130 > > Australia, Brisbane > > 0730870178 > > Australia, Melbourne > > 0382561740 > > Australia, Perth > > 0861884572 > > Australia, Sydney > > 0289852326 > > Austria, Vienna > > 012534978196 > > Belgium, Brussels > > 027920405 > > China, All Cities Domestic > > 4006205013 > > China, All Cities Domestic > > 8008190132 > > Czech Republic, Prague > > 239014984 > > Denmark, Copenhagen > > 32729215 > > Finland, Helsinki > > 0923194436 > > France, Paris > > 0170377140 > > Germany, Berlin > > 030300190579 > > Germany, Frankfurt > > 06922222594 > > Hong Kong, Hong Kong > > 85230730429 > > Hungary, Budapest > > 7789030 > > India, Bangalore > > 08039417180 > > India, Chennai > > 04430061276 > > India, Hyderabad > > 04030644055 > > India, Mumbai > > 02230985358 > > India, New Delhi > > 01139417180 > > Ireland, Dublin > > 014367793 > > Italy, Milan > > 0236269529 > > Japan, Tokyo > > 0345807897 > > Korea (South), Seoul > > 0234837408 > > Lithuania, Vilnius > > 52054226 > > Luxembourg, Luxembourg > > 24871157 > > Malaysia, Kuala Lumpur > > 0348190012 > > Netherlands, Amsterdam > > 0207975872 > > Norway, Oslo > > 21033188 > > Poland, Warsaw > > 222120148 > > Romania, Bucharest > > 0318103711 > > Russian Federation, Moscow > > 4999221989 > > Singapore, All Cities > > 64840858 > > Singapore, All Cities > > 64840858 > > Slovak Republic, Bratislava > > 0233456338 > > Slovenia, Ljubljana > > 016003991 > > Spain, Barcelona > > 935452328 > > Spain, Madrid > > 914146284 > > Sweden, Stockholm > > 0850513770 > > Switzerland, Geneva > > 0225927881 > > Switzerland, Zurich > > 0445803463 > > United Kingdom, All Cities > > 02035746870 > > United Kingdom, All Cities > > 08445790678 > > United States, All Cities > > 2127295016 > > Vietnam, Ho Chi Minh > > 84838012421 > > **International Toll Free Numbers are subject to change. Before each > conference, refer to the numbers above for the most current information. > Always use your Toll number as a backup. > > > > Helpful keypad commands: > > *0 Operator assistance - conference > > 00 Operator assistance-individual > > *1 Dial-out to a participant - leader only > > *2 Begin/end conference record (leader only) > > *3 Change entry/exit method (recorded names, tones, silence) - > leader only > > *4 Private roll call > > *5/#5 Mute/unmute all participant lines - leader only > > *6/#6 Mute/unmute your own line > > *7/#7 Lock/unlock conference (including operator) - leader only > > *8 Allow/disallow conference continuation - leader only > > *9 Start/join sub-conferencing > > 11 Third-party conference start - bypass hold music to start call as > leader > > *51/#51 Lecture mode on/off – leader only > > #99 Disconnect all lines except leader’s – leader only > > *# Participant count > > ** List available keypad commands > > -- > > "Have you tried turning it off and on again" - The IT Crowd > > > > > > _______________________________________________ > > wtp-dev mailing list > > [email protected] > > https://dev.eclipse.org/mailman/listinfo/wtp-dev > > > > _______________________________________________ > > wtp-dev mailing list > > [email protected] > > https://dev.eclipse.org/mailman/listinfo/wtp-dev > > > > > > > > > > -- > > "Have you tried turning it off and on again" - The IT Crowd > > _______________________________________________ > > m2e-wtp-dev mailing list > > [email protected] > > http://dev.eclipse.org/mailman/listinfo/m2e-wtp-dev > > _______________________________________________ > m2e-wtp-dev mailing list > [email protected] > http://dev.eclipse.org/mailman/listinfo/m2e-wtp-dev > -- "Have you tried turning it off and on again" - The IT Crowd
_______________________________________________ m2e-wtp-dev mailing list [email protected] http://dev.eclipse.org/mailman/listinfo/m2e-wtp-dev
