* doc/m4.texinfo (Format): Add a test.
* NEWS: Document the fix.
* THANKS: Update.

Signed-off-by: Eric Blake <ebl...@redhat.com>
---

Here's my followup to test your patch.  Thanks again.

 ChangeLog      |    7 +++++++
 NEWS           |    3 +++
 THANKS         |    1 +
 doc/m4.texinfo |   13 +++++++++++++
 4 files changed, 24 insertions(+), 0 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 4141f53..ec3852a 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2010-08-30  Eric Blake  <ebl...@redhat.com>
+
+       Test previous commit.
+       * doc/m4.texinfo (Format): Add a test.
+       * NEWS: Document the fix.
+       * THANKS: Update.
+
 2010-08-30  Carlo Teubner  <....@gmail.com>  (tiny change)

        Avoid a crash with bad format string.
diff --git a/NEWS b/NEWS
index a642711..886ab31 100644
--- a/NEWS
+++ b/NEWS
@@ -2,6 +2,9 @@ GNU M4 NEWS - User visible changes.

 * Noteworthy changes in release 1.4.15 (2010-08-??) [stable]

+** Fix regression introduced in 1.4.9b where the format builtin could
+   crash on an invalid format string.
+
 ** Fix compilation against newer glibc, and on AIX 7.1BETA.

 ** A number of portability improvements inherited from gnulib.
diff --git a/THANKS b/THANKS
index 5fed251..b0f0c19 100644
--- a/THANKS
+++ b/THANKS
diff --git a/doc/m4.texinfo b/doc/m4.texinfo
index 062ecb2..092995b 100644
--- a/doc/m4.texinfo
+++ b/doc/m4.texinfo
@@ -6097,6 +6097,19 @@ Format
 @result{}
 @end example

+...@ignore
+...@comment Expose a crash with a bad format string fixed in 1.4.15.
+...@comment Unfortuntely, 8-bit bytes are hard to check for; but the
+...@comment exit status is enough to sniff the crash in broken versions.
+
+...@comment xerr: ignore
+...@example
+format(`%'format(`%c', `128'))
+...@result{}
+...@end example
+...@end ignore
+
 @node Arithmetic
 @chapter Macros for doing arithmetic

-- 
1.7.2.2


_______________________________________________
M4-patches mailing list
M4-patches@gnu.org
http://lists.gnu.org/mailman/listinfo/m4-patches

Reply via email to