LGTM On Sat, Sep 6, 2008 at 7:56 AM, Erik Andrén <[EMAIL PROTECTED]> wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > > > David Sharp wrote: > | geez, I had no idea you were including C files... Please, let's clean > that up. > | > | Can you send a patch to the list for us to review? That's easier than > | guessing what exactly those arrows mean in your diagram. > | > | 2008/9/4 Erik Andrén <[EMAIL PROTECTED]>: > |> Hi, > |> > |> The current driver structure with only one source file including other .c > |> files directly isn't pretty and causes unnecessary name-space collisions. > |> (The same define may not exist in several sensors, for instance.) > |> Also, the current structure isn't compatible when linux kernel > integration. > |> > |> I've been playing with an alternative reorganization and has come up with > |> the following structure: > |> > |> The core functionality is stored in > |> m5602_core.c with the v4l2 specific functions remaining in m5602_v4l2.c > |> > |> The sensor code remain as before but includes a m5602_sensor.h header > |> containing sensor specific defines and data structures. > |> > |> m5602_sensor.h in turn calls m5602_bridge.h containing m5602 specific > data > |> structures. > |> > |> The attached picture contains a dependency graph. > |> > |> If anyone has some comments regarding this structure, please voice them > |> soon, or else I will merge this change into the m5602 branch. > |> > |> Regards, > |> Erik > |> > |> > > I've created a new branch m5602-newlayout which contains the new layout > ~ proposition. > > Regards, > Erik > > > |> > |> ------------------------------------------------------------------------- > |> This SF.Net email is sponsored by the Moblin Your Move Developer's > challenge > |> Build the coolest Linux based applications with Moblin SDK & win great > |> prizes > |> Grand prize is a trip for two to an Open Source event anywhere in the > world > |> http://moblin-contest.org/redirect.php?banner_id=100&url=/ > |> _______________________________________________ > |> M560x-driver-devel mailing list > |> [email protected] > |> https://lists.sourceforge.net/lists/listinfo/m560x-driver-devel > |> > |> > | > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.6 (GNU/Linux) > > iD8DBQFIwpoMN7qBt+4UG0ERAoD/AKC1gAVZxs/RmbFc/hk/UKVWxhyF1gCfY1iQ > znXJQAtYIMk8y4Mz2UaZZu4= > =89fS > -----END PGP SIGNATURE----- >
------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ M560x-driver-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/m560x-driver-devel
