Hi Erik,
I agree with you, I had no intention to commit it as is. I wrote this patch in
a hurry this morning and I didn't take time to make it better.
I also think we only need to test pos[2].
Greg
----- Message d'origine ----
De : Erik Andrén <[EMAIL PROTECTED]>
À : Grégory Lardière <[EMAIL PROTECTED]>
Cc : m560x-driver-devel <[email protected]>
Envoyé le : Jeudi, 18 Septembre 2008, 9h54mn 23s
Objet : Re: [M560x-driver-devel] Re : Re : possible solution for s5k83a
problems with light
2008/9/18 Grégory Lardière <[EMAIL PROTECTED]>
Hi all,
I think I fixed the image distortion too. Please, test this new patch.
When appending to the same frame, we need to remove only 4 bytes of header,
instead of 6.
The code is still ugly, but don't worry, I'll clean it up before committing it
to svn, if it works for everyone.
Greg
Hi,
Looks good to me but please don't use a static variable, add another member to
the m5602_camera struct instead.
Also, is it really necessary to test both pos[2] and pos[3] against last,
wouldn't just pos[2] suffice?
Regards,
Erik
Re
----- Message d'origine ----
De : Lukáš Karas <[EMAIL PROTECTED]>
À : m560x-driver-devel <[email protected]>
Envoyé le : Mercredi, 17 Septembre 2008, 21h41mn 52s
Objet : [M560x-driver-devel] Re : possible solution for s5k83a problems with
light
Sorry, I forget add attachment to previous mail...
and url: http://www.karry.wz.cz/download/light.patch
______________________________________________________________
> Od: [EMAIL PROTECTED]
> Komu: "Grégory Lardière" <[EMAIL PROTECTED]>
> CC: "Lukáš Karas" <[EMAIL PROTECTED]>, m560x-driver-devel
> <[email protected]>
> Datum: 17.09.2008 20:56
> Předmět: Re: [M560x-driver-devel] Re : possible solution for s5k83a problems
> with light
>
>Work great for me!! Nice job :-)
>
>2008/9/17 Grégory Lardière <[EMAIL PROTECTED]>:
>> Hi,
>>
>> Your findings are very interesting. I also have image corruption when light
>> is too bright with the s5k4aa sensor. I have a work around but it only works
>> in 640x480 when sub-sampling is enabled, so a better solution would be nice.
>> I made a patch which almost fixes the pb : when a frame header has the same
>> frame number as the current frame, just append data to the current frame.
>> This fixes jerkiness but there is still an image deformation. Could you try
>> this patch and tell if it works for you?
>>
>> Greg
>>
>> ----- Message d'origine ----
>> De : Lukáš Karas <[EMAIL PROTECTED]>
>> À : m560x-driver-devel <[email protected]>
>> Envoyé le : Mercredi, 17 Septembre 2008, 3h22mn 14s
>> Objet : [M560x-driver-devel] possible solution for s5k83a problems with
>> light
>>
>> Hi all
>>
>> Is it possible somehow throwout frames from stream?
>> I identify frame number in frame deliminer.
>> When I am shining with lamp direct to sensor, some frames are send several
>> times
>> (frames with same number)
>> and image from camera is bugly.
>>
>> I find repetitive frame number in usb snoop from windows too, when i was
>> shining to sensor,
>> but image was greath!
>>
>> Maybee if we throwout "damage" frames, image will be stable as in windows...
>>
>> I create small test patch for repetitive frame number.
>>
>> patch: http://www.karry.wz.cz/download/light_test.patch
>> screencast: http://www.karry.wz.cz/download/test_screencast.avi
>>
>> Please read the patch and see screencast, you understand what I wrote.
>>
>> Is anybody capable create frame drop for test my idea?
>>
>> Regards Lukas
>>
>>
>>
>>
>>
>>
>> -------------------------------------------------------------------------
>> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
>> Build the coolest Linux based applications with Moblin SDK & win great
>> prizes
>> Grand prize is a trip for two to an Open Source event anywhere in the world
>> http://moblin-contest.org/redirect.php?banner_id=100&url=/
>> _______________________________________________
>> M560x-driver-devel mailing list
>> [email protected]
>> https://lists.sourceforge.net/lists/listinfo/m560x-driver-devel
>>
>>
>
>
>
>--
>S pozdravem / Best regards
>Marek Stopka
>Official openSUSE community member
>Kontakty / Contacts
>Mobil/Cell phone: 774 59 79 40
>E-mail: [EMAIL PROTECTED]
>WEB: www.m4r3k.org
>
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
M560x-driver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/m560x-driver-devel
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
M560x-driver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/m560x-driver-devel
